refactor: switch to upstream openapi #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
AdrienFromToulouse
approved these changes
Sep 26, 2024
tsconfig.json
Outdated
| @@ -26,7 +26,7 @@ | |||
| // "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */ | |||
|
|
|||
| /* Strict Type-Checking Options */ | |||
| "strict": true, /* Enable all strict type-checking options. */ | |||
| // "strict": true, /* Enable all strict type-checking options. */ | |||
There was a problem hiding this comment.
what is the reason to switch this config off?
There was a problem hiding this comment.
the main reason was the lack of types for the lib. But I adjusted the type definitions we already had
chriswk
requested changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unleash proxy is still using https://github.com/Unleash/express-openapi, which is the forked and archived version of https://github.com/wesleytodd/express-openapi
As all required changes are already pushed to the upstream project, we can migrate to the upstream project.
This was already done for the unleash server (see Unleash/unleash#5259) a while back but not for unleash proxy.
It also updates the lib to the latest version so that security patches can be applied (which we need to do very soon due to path-to-regexp etc.). See https://github.com/Unleash/unleash/pull/8170/files