feat: validate that id is number or we throw our our source code #6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -354,6 +355,7 @@ export default class UserAdminController extends Controller { | |||
| ...getStandardResponses(400, 401, 404), | |||
| }, | |||
| }), | |||
| idNumberMiddleware(), | |||
There was a problem hiding this comment.
❌ Getting worse: Large Method
UserAdminController.constructor increases from 303 to 306 lines of code, threshold = 70
| @@ -159,6 +160,7 @@ export class SegmentsController extends Controller { | |||
| 200: createResponseSchema('segmentStrategiesSchema'), | |||
| }, | |||
| }), | |||
| idNumberMiddleware(), | |||
There was a problem hiding this comment.
❌ Getting worse: Large Method
SegmentsController.constructor increases from 196 to 200 lines of code, threshold = 70
| @@ -109,6 +110,7 @@ export default class PatController extends Controller { | |||
| ...getStandardResponses(401, 403, 404), | |||
| }, | |||
| }), | |||
| idNumberMiddleware(), | |||
There was a problem hiding this comment.
❌ Getting worse: Large Method
PatController.constructor increases from 75 to 76 lines of code, threshold = 70
FredrikOseberg
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were not validating that the ID was a number, which sometimes resulted in returning our database queries (source code) to the frontend. Now, we have validation middleware.