Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add enterprise extension point to enable change requests on project creation #6881

Merged

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Apr 17, 2024

This PR adds an optional function parameter to the createProject function that is intended to enable change requests for the newly created project.

The assumption is that all the logic within will be decided in the enterprise impl. The only thing we want to verify here is that it is called after the project has been created.

This change adds a new extension point to the project service that
allows enterprise Unleash to add custom logic to the project service.

The purpose of this is to allow enterprise Unleash to enable change
request for a set of environments on project creation.
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 9:55am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 9:55am

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

src/lib/features/project/project-service.ts Show resolved Hide resolved
src/lib/features/project/project-service.ts Show resolved Hide resolved
src/lib/features/project/project-service.ts Show resolved Hide resolved
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

@thomasheartman thomasheartman merged commit bf4c29b into main Apr 18, 2024
7 checks passed
@thomasheartman thomasheartman deleted the chore/project-service-add-enterprise-extension-point branch April 18, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants