Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial sketch for the lifecycle tooltip #6899

Merged
merged 3 commits into from
Apr 23, 2024
Merged

feat: initial sketch for the lifecycle tooltip #6899

merged 3 commits into from
Apr 23, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Apr 22, 2024 •
edited
Loading

About the changes

Screenshot 2024-04-22 at 13 40 02

Goals of this PR:

  • find a way to occupy full space for the purple/bottom part despite the parent tooltip having padding (solved with negative margin and matching border radius)
  • create main layout for the tooltip components

Next PRs:

  • add lifecycle icons and icon timeline
  • create other stages (pre-live, live, completed and archived)
  • connect to real data source
  • test when the component is ready

Important files

Discussion points

@vercel Vercel
Copy link

vercel bot commented Apr 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 0:00am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 0:00am

FredrikOseberg
FredrikOseberg approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top section needs slightly more padding bottom. Otherwise LGTM.

@kwasniew
Copy link
Contributor Author

Will adjust with the next PR that adds stage timeline

@kwasniew kwasniew merged commit 131e9dd into main Apr 23, 2024
13 checks passed
@kwasniew kwasniew deleted the lifecycle-tooltip-initial-ui-sketch branch April 23, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredrikOseberg FredrikOseberg FredrikOseberg approved these changes

@codescene-delta-analysis codescene-delta-analysis[bot] codescene-delta-analysis[bot] approved these changes

@Tymek Tymek Awaiting requested review from Tymek

Assignees

@kwasniew kwasniew

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwasniew @FredrikOseberg