feat: feature lifecycle complete and uncomplete #6927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sjaanus
commented
Apr 25, 2024
| @@ -79,11 +90,6 @@ export class FeatureLifecycleService extends EventEmitter { | |||
| ), | |||
| ); | |||
| }); | |||
| this.eventStore.on(FEATURE_COMPLETED, async (event) => { | |||
There was a problem hiding this comment.
This is not needed, this event is not coming from anything external.
kwasniew
reviewed
Apr 25, 2024
src/lib/features/feature-lifecycle/feature-lifecycle-controller.ts
Outdated
Show resolved
Hide resolved
kwasniew
reviewed
Apr 25, 2024
src/lib/features/feature-lifecycle/feature-lifecycle-service.ts
Outdated
Show resolved
Hide resolved
kwasniew
reviewed
Apr 25, 2024
src/lib/features/feature-lifecycle/feature-lifecycle.e2e.test.ts
Outdated
Show resolved
Hide resolved
kwasniew
approved these changes
Apr 25, 2024
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -1,9 +1,11 @@ | |||
| import { | |||
| CLIENT_METRICS, | |||
| FEATURE_ARCHIVED, | |||
| FEATURE_COMPLETED, | |||
There was a problem hiding this comment.
❌ New issue: String Heavy Function Arguments
In this module, 57.1% of all arguments to its 10 functions are strings. The threshold for string arguments is 39.0%
Comment on lines
-71
to
-72
| eventStore.emit(FEATURE_COMPLETED, { featureName }); | ||
| await reachedStage('completed'); |
There was a problem hiding this comment.
✅ No longer an issue: Large Method
'can insert and read lifecycle stages' is no longer above the threshold for lines of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a way to complete and uncomplete feature.