fix: no requests before project loaded #7096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
May 21, 2024
| @@ -5,5 +5,5 @@ export const useShowDependentFeatures = (project: string) => { | |||
| const { dependenciesExist } = useCheckDependenciesExist(project); | |||
| const { isOss } = useUiConfig(); | |||
|
|
|||
| return Boolean(isOss() ? dependenciesExist : true); | |||
| return Boolean(project) && Boolean(isOss() ? dependenciesExist : true); | |||
There was a problem hiding this comment.
dependent features were checking pending change requests under the hood but they were checking them for the empty project. The empty project came from the placeholder used in useFeature. After this fix if the useFeature returns the placeholder project (with empty project) we don't show dependencies section.
kwasniew
commented
May 21, 2024
| featureId={feature.name} | ||
| onComplete={refetchFeature} | ||
| <ConditionallyRender | ||
| condition={Boolean(feature.project)} |
There was a problem hiding this comment.
same guard for the mark completed. We need project since hooks inside the dialogue assume it's not empty
sjaanus
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Check if project is provided because we don't want hooks making 404 requests during initial data load for the project.
Important files
Discussion points