Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show docs with icons in sidebar #7109

Merged
merged 9 commits into from
May 22, 2024
Merged

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented May 22, 2024

Adds icons to sidebar documentation and removes the link when you can't interact with it.

I'm a little concerned that this won't be very accessible at the moment, because we don't announce that anything has changed (i.e. there's no way to find out that the text has changed if you can't see it), and the text isn't labeled as describing anything. (this is being addressed in #7110 )

image

There's a few caveats to this:

  1. we don't set a min height at the moment. I've avoided this because we use the sidebar a number of other places and I wanted to touch as little as possible. This means we can still get height adjustments
  2. The new project icon doesn't have the same proportions as the mui icons. This adds some additional jank. We should probably look at this, though.

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 11:36am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 11:36am

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still there, I've just removed the stroke and fill, so that we can set it per instance.

@thomasheartman thomasheartman merged commit 78fcdbf into main May 22, 2024
10 checks passed
@thomasheartman thomasheartman deleted the feat/1-2386-sidebar-docs branch May 22, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant