feat: user profile preview #7150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
May 24, 2024
| @@ -216,7 +216,7 @@ const ShowHide: FC<{ mode: 'full' | 'mini'; onChange: () => void }> = ({ | |||
| display: 'flex', | |||
| justifyContent: 'space-between', | |||
| alignItems: 'center', | |||
| margin: theme.spacing(2, 1, 0, 2), | |||
| margin: theme.spacing(2, 1, 0, mode === 'mini' ? 1 : 2), | |||
There was a problem hiding this comment.
fixed show/hide nav layout for mini icons
kwasniew
commented
May 24, 2024
| aria-expanded={showProfile} | ||
| onClick={() => setShowProfile((prev) => !prev)} | ||
| > | ||
| <StyledUserAvatar user={profile} /> |
There was a problem hiding this comment.
moved from UserProfileContent to the UserProfile itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Moving user profile info (name and email) from behind the avatar to the top bar. This change is not flagged since it looks good for current and new code. The new profile is modelled as a button so that keyboard navigation works fine.
Current desktop view (username and profile removed from the dropdown and added to top bar):
New desktop view (divider between icons and new profile):
Current and new mobile view (identical):
Also works with very long names and emails:
Important files
Discussion points