Fix for Dialog_Options null pointer exception #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrackPot97
pushed a commit
to CrackPot97/Hardcore-SK
that referenced
this pull request
May 9, 2023
Integrated fix from UnlimitedHugs/RimworldHugsLib#97 into HSK's Hugslib
|
Seems to have been resolved as part of the 1.5 update. Thank you for investigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #90 #93
related #94 but that one seems to be missing a commit or something as it doesn't actually change
SettingsModProxywhich is the issue that causes the exception. This takes a slightly different approach and matches the mod content packs up with the settings packs on-the-fly when it does the injection. I'm not sure what performance implications this has, I haven't benchmarked itI have tested it with my current modlist (168 strong) and it appears to work with no issues