Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename to match settings.run + Gobat spelling #17

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

TiMXL73
Copy link
Contributor

@TiMXL73 TiMXL73 commented Jan 12, 2024

  • settings.run was attempting to copy $folder/default_files/procedures.sql.default which did not exists causing an error. The file was actually called $folder/default_files/procedure.sql.default without a trailing S. I'm adding the S to match other filenames.
  • proceduresGobatExternal.sql.default should be Golbat.

- `settings.run` was attempting to copy `$folder/default_files/procedures.sql.default` which did not exist causing an error. The file was actually called `$folder/default_files/procedure.sql.default` without a trailing S. I am adding an S to match other filenames.
- `proceduresGobatExternal.sql.default` should be Golbat with an L.
@Fabio1988
Copy link
Collaborator

Hmm probably introduced by c31f83b

@TiMXL73
Copy link
Contributor Author

TiMXL73 commented Jan 12, 2024

41d644f#diff-bfdd2938c0d2849e6eb7b83a94b1dd085163fea9a939931a5406c73df5916bc2

settings.run was changed with the new filename but the physical file was not renamed. It appears to be the only instance that was missed from the mass renaming.

@dkmur dkmur merged commit 6de579a into UnownHash:develop Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants