BREAKING CHANGE: revert table extraction off by default for PDFs and images #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…images <- Ingest test fixtures update (#3036) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: MthwRobinson <MthwRobinson@users.noreply.github.com>
scanny
approved these changes
May 16, 2024
…nstructured into 3021/default-table-off
…images <- Ingest test fixtures update (#3046) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: MthwRobinson <MthwRobinson@users.noreply.github.com>
MalteHB
reviewed
May 21, 2024
Comment on lines
143
to
+144
| headers: dict[str, str] = {}, | ||
| skip_infer_table_types: list[str] = [], | ||
| skip_infer_table_types: list[str] = ["pdf", "jpg", "png", "heic"], |
There was a problem hiding this comment.
You should really never do this. Initializing mutable default parameters, such as skip_infer_table_types, with a mutable data type (e.g., list, dict, etc.) can lead to unexpected behavior. The default value is shared across all instances of the function call, meaning that any modification to this parameter within one function call will affect subsequent calls. This can introduce subtle bugs that are difficult to trace and debug. Instead, initialize the parameter with None and set the default value inside the function if it is None.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 23, 2024
This PR aims to add backward compatibility for the deprecated `pdf_infer_table_structure` parameter. A missing part of turning table extraction for PDFs and Images off by default in #3035, which was turned on in #2588. --------- Co-authored-by: ryannikolaidis <1208590+ryannikolaidis@users.noreply.github.com> Co-authored-by: christinestraub <christinestraub@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3021 . Turns table extraction for PDFs and images off by default. The default behavior originally changed in #2588 . The reason for reversion is that some users did not realize turning off table extraction was an option and experience long processing times for PDFs and images with the new default behavior.