Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reenable arm64 builds for docker #3045

Merged
merged 9 commits into from
May 17, 2024
Merged

fix: reenable arm64 builds for docker #3045

merged 9 commits into from
May 17, 2024

Conversation

MthwRobinson
Copy link
Contributor

@MthwRobinson MthwRobinson commented May 17, 2024

Summary

Closes #3034 and reenables ARM64 in the docker build and publish job. This was taken out in #3039 because we've only build libreoffice for AMD64 and not ARM64. If Chainguard publishes an apk for libreoffice, we can support a Chainguard image for both architectures. The smoke test now differs for both architectures, to reflect differences in the directory structure.

Testing

Build and publish ran successfully for ARM64 (job here) and AMD64 (job here).

Copy link
Collaborator

@christinestraub christinestraub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MthwRobinson MthwRobinson added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 9cd0e70 May 17, 2024
42 checks passed
@MthwRobinson MthwRobinson deleted the 3041/reenable-arm branch May 17, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants