Enhancement: improve detect_filetype
warning to include filename
#355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208
Hello!
Pull Request overview
detect_filetype
warning to include filename if provided.Details
See #208 for details on the desired improvement.
Reproduction
Consider the following script to reproduce the warning:
I've used the already-available
example-docs/fake-email-header.eml
as libmagic responds with an unknown mime type for it. This makes it a good target file to test out these changes with.On the
main
branch, the output of this script is:After this PR, the output will be:
I'm open to feedback, as always. And feel free to let me know if I need to handle any merge conflicts.