deformVertexes is broken (Water rendering bugs)

[illwieckz]

There is a now well-known water bug on Station15 map:

But we can see the exact same bug on the unofficial nexus6 map, so it is not a specific station15 issue and perhaps it is not a map issue but a renderer issue.

As you see, the more time we wait, the more ugly the bug becomes:

Glitches increase with time, and it could be worse depending of the point of view:

The glitches can be visible in other rooms separated by walls and closed doors:

It can affect lights too (water broken texture illuminated by lights or reflecting lights):

The bug was already here in alpha 35.

[illwieckz]

It's seems to affect all textures using a water and lava keywords, the problem appears on citadel (water), vega (water), ancient remains (lava). All maps I tested with water/lava textures failed to render it correctly, with the same glitches.

Also, the glitches pass through all the map.

Vega (water):

Citadel (water):

Ancient Remains (lava):

Pulse (water):

In fact, when we are inside the water/lava; the wobbly effect that affects vision is here, if there is some fog in water, it works too. But the surface of the water/lava is not here, and this is this surfaces which is buggy.

Usually the water surface makes wave (deforms itself vertically), and the lava surface deforms itself horizontally. These two effects are broken.

The only map with working water is Cleanser, but the surface does not have waves like water nor horizontal deformations like lava, so it seems it works because the mapper does not used the keyword “water”, it's just a texture like a wall texture.

[illwieckz]

commenting out deformVertexes lines in shaders fixes many issues, this one is used to do wave for example, on water surface, on tree leafs, or duplicating flames in some angles…

[illwieckz]

This bug does not affect only water, but enhanced fire and animated leafs. Textures transverse all the map and reflects light badly. Also, leafs appears on bullet impact, and it affects clothes drying on the line too. 😛

[Viech]

@gimhael, any idea?

[gimhael]

Yes, all deforms are broken. I have a fix on my lokal particles branch, but have to clean it up a bit. Expect a fix in the next days.

[illwieckz]

Awesome! Too bad this happen right after the release. 😝 Thanks for your work!

[illwieckz]

The current gimhael's sprites branch fix all these issues (and fix the “moving cloud” skybox bug too).

[Viech]

Sweet, then this can be closed with a commit reference once it reaches master or a for-* branch.

[illwieckz]

Hi, do you know if the sprites branch will be merged before tomorrow's release?

[Viech]

origin/for-0.38.0..origin/sprites is empty right now, so it seems that it was merged and will be in the release.

[illwieckz]

nice !