some cbse related cleanups #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Utility.cpp as well) External facades to CBSE entities and components in a dedicated Entites.cpp This aims to reduce (re)compilation times by avoiding CBSE.h includes in code that isn't instantiating entities. Instead of CBSE.h the code can simply include Entities.h and use the forward declarations and facades there for simple lookups. This will also be a place for general migration help functions.
slipher
reviewed
Nov 3, 2018
|
Good stuff |
|
LGTM ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foremost it removes/replaces several CBSE.h includes so that changes to entities or component headers won't result in a full rebuild anymore. There's still a lot build then, but less now.
While working on some entity migrations, it started to become a bit annoying that a lot of change-unrelated things had to be rebuild due to the include.
This PR does not contain any migrations yet in light of the upcoming release, but some other cleanups like unused field removal.