Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: add a Disconnect button on connecting and downloading screen #2958

Merged
merged 1 commit into from Mar 30, 2024

Conversation

illwieckz
Copy link
Member

Add a Disconnect button on connecting and downloading screen.

Also intercept Escape key to disconnect.

Mutualize a bit the code.

20240326-222727-000 unvanquished

Add a Disconnect button on connecting and downloading screen.

Also intercept Escape key to disconnect.

Mutualize a bit the code.
@illwieckz
Copy link
Member Author

According to @perturbed comment, I can't intercept Escape in map loading screen unfortunately:

26 22:43 <illwieckz> do someone knows how it is coded in Unvanquished that the map loading screen has no user interaction?
26 22:43 <perturbed> illwieckz, it's 1 frame
26 22:44 <illwieckz> 1 frame when compiling GLSL
26 22:44 <illwieckz> but not when loading assets
26 22:44 <illwieckz> and making a progress bar
26 22:44 <perturbed> no it's all 1 frame
26 22:44 <illwieckz> what
26 22:44 <illwieckz> ok
26 22:44 <illwieckz> so, no way to intercept escape?
26 22:44 <illwieckz> I was not expecting to intercept escape when compiling GLSL
26 22:45 <illwieckz> but I was hoping to do so while loading assets
26 22:45 <perturbed> no way
26 22:45 <illwieckz> :'(

@illwieckz illwieckz changed the title ui: add a Disconnect button on connecting and downloading screen. ui: add a Disconnect button on connecting and downloading screen Mar 26, 2024
@illwieckz illwieckz added A-UI T-Feature-Request Proposed new feature labels Mar 27, 2024
@illwieckz illwieckz merged commit e08de89 into master Mar 30, 2024
1 check passed
@illwieckz illwieckz deleted the illwieckz/disconnect branch March 30, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI T-Feature-Request Proposed new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants