Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pathname used in express initialisation #255

Merged
merged 1 commit into from
Oct 19, 2024
Merged

fix: pathname used in express initialisation #255

merged 1 commit into from
Oct 19, 2024

Conversation

harbassan
Copy link
Contributor

Describe the issue

The backend was crashing because the pathname was still using the old commonjs way and didnt work with esm.

Describe the solution

changed it to use functions built with esm.

Risk

None.

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

wjin-lee
wjin-lee approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@harbassan harbassan merged commit ba9824a into master Oct 19, 2024
7 checks passed
@harbassan harbassan deleted the fix-pathname branch October 19, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjin-lee wjin-lee wjin-lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harbassan @wjin-lee