This repository has been archived by the owner on Sep 29, 2019. It is now read-only.
Issue #6 rawphenotypes hook alter() implementations #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow raw phenotypes module to alter values.
- Replaced the hard-coded email address with a system variable. This
can be set by calling a Drupal API
variable_set('kp_rawpheno_support_email’, ‘support email’).
- Allow admin to set custom support email address using terminal - Set the default support email to Drupal Admin with id # 0 or Drupal site wide email address provided during Drupal installation/setup.
laceysanderson
commented
Mar 15, 2018
kp_nodes.module
Outdated
| * otherwise, the module will load email from either the Drupal user 0 | ||
| * or the Drupal site wide mail. | ||
| */ | ||
| function kp_nodes_rawpheno_support_email_alter(&$support_email) { |
There was a problem hiding this comment.
This function should only provide @reynoldtan's email. As mentioned in the related pull request the default email should be provided via rawphenotypes.
kp_nodes.module
Outdated
| */ | ||
|
|
||
| // When searching for new columns. | ||
| // in rawpheno.upload.form.inc : rawpheno_upload_form_stage_review(). |
There was a problem hiding this comment.
Please be more descriptive in your docblocks. Also there should not be any code between the docblock and the function header. The kp_nodes_rawpheno_support_email_alter() docblock was perfect :-) so just keep with that format for All Alter functions while substituting in the correct info (e.g. columns, etc.).
kp_nodes.module
Outdated
| // When saving and validating data. | ||
| // in rawpheno.upload.form.inc : rawpheno_validate_excel_file(). | ||
| // rawpheno_load_spreadsheet(). | ||
| function kp_nodes_rawpheno_ignorecols_valsave_alter(&$skip, &$project_name) { |
kp_nodes.module
Outdated
| } | ||
| } | ||
|
|
||
| // Check existence of column(s) in columns array. |
kp_nodes.module
Outdated
| return $cols_i; | ||
| } | ||
|
|
||
| // Define a set columns to ignore. |
|
🎉 |
laceysanderson
deleted the
Issue-#6---Rawphenotypes-hook_alter()-implementations
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should have been created when the changes were submitted for review. See Issue #6