Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ratio wrapper #46

Closed
chriswallace opened this issue May 12, 2012 · 5 comments
Closed

Fix ratio wrapper #46

chriswallace opened this issue May 12, 2012 · 5 comments

Comments

@chriswallace
Copy link
Contributor

Not sure what happened here but it's definitely not working properly: http://cl.ly/1T0l1n2M202W460b1c3m

Steps to Recreate:

  1. Get this image: http://cl.ly/3d1o3I1G2Z1q3Y243S03
  2. Create a new team member.
  3. Attach that image as post thumbnail.
  4. View homepage template with team member thumbnails.
@chriswallace
Copy link
Contributor Author

If I understand the problem completely, it should not be a problem if we just use add_image_size() to define images using the hard crop option, which trims all images down to the correct size.

@garand
Copy link
Contributor

garand commented May 13, 2012

I believe @matthewsimo point in doing this was to not use wordpress's cropping.

@garand
Copy link
Contributor

garand commented May 13, 2012

Alright I see what the issue is. We need to either use JS or PHP, I think JS will suffice. I'll look into finishing a solution today.

@chriswallace
Copy link
Contributor Author

I removed this from our code in favor of PHP cropping until WP core implements a location for cropping.

@garand
Copy link
Contributor

garand commented May 17, 2012

Sounds good. Perf will be better because of it. < JS

Sent from my iPhone

On May 17, 2012, at 5:24 PM, Chris Wallace
reply@reply.github.com
wrote:

I removed this from our code in favor of PHP cropping until WP core
implements a location for cropping.


Reply to this email directly or view it on GitHub:
#46 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants