-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ratio wrapper #46
Comments
If I understand the problem completely, it should not be a problem if we just use add_image_size() to define images using the hard crop option, which trims all images down to the correct size. |
I believe @matthewsimo point in doing this was to not use wordpress's cropping. |
Alright I see what the issue is. We need to either use JS or PHP, I think JS will suffice. I'll look into finishing a solution today. |
I removed this from our code in favor of PHP cropping until WP core implements a location for cropping. |
Sounds good. Perf will be better because of it. < JS Sent from my iPhone On May 17, 2012, at 5:24 PM, Chris Wallace I removed this from our code in favor of PHP cropping until WP core Reply to this email directly or view it on GitHub: |
Not sure what happened here but it's definitely not working properly: http://cl.ly/1T0l1n2M202W460b1c3m
Steps to Recreate:
The text was updated successfully, but these errors were encountered: