repl: fixed prompt_object_options return value type #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, repl.helpers.prompt_object_options was returning a dict with string keys. This was making validation of object option requirements fail inadvertently. Consequently, prompt of sub options (eg. format options, install condition configuration, etc) never happened because they depend on this validation. A type checking was added into uhu.core.validate_option_requirements to prevent this kind of bug. This modification made repl.helpers.prompt_object_options tests fail as expected. Finally, a proper fix was applied into prompt_object_options. Signed-off-by: Pablo Palácios <ppalacios992@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, repl.helpers.prompt_object_options was returning a dict
with string keys. This was making validation of object option
requirements fail inadvertently. Consequently, prompt of sub
options (eg. format options, install condition configuration, etc)
never happened because they depend on this validation.
A type checking was added into uhu.core.validate_option_requirements
to prevent this kind of bug. This modification made
repl.helpers.prompt_object_options tests fail as expected. Finally, a
proper fix was applied into prompt_object_options.
Signed-off-by: Pablo Palácios ppalacios992@gmail.com