Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add firmware update functionality for BOS Miner #147

Merged
merged 10 commits into from
Jun 5, 2024
Merged

Add firmware update functionality for BOS Miner #147

merged 10 commits into from
Jun 5, 2024

Conversation

1e9abhi1e10
Copy link
Contributor

@1e9abhi1e10 1e9abhi1e10 commented May 20, 2024 •
edited
Loading

This PR aims to add update firmware functionality for BOS Miner.

@1e9abhi1e10 1e9abhi1e10 marked this pull request as draft May 20, 2024 18:15
@1e9abhi1e10
Copy link
Contributor Author

I will add additional steps for the update_firmware process in the upcoming commits, along with corresponding tests.

@b-rowan
Copy link
Collaborator

b-rowan commented May 20, 2024

Can you switch out aiohttp for httpx? Already using httpx as a dependency, so I would like to use that.

b-rowan
b-rowan reviewed May 20, 2024
View reviewed changes
pyasic/miners/base.py Outdated Show resolved Hide resolved
@1e9abhi1e10
Copy link
Contributor Author

Can you switch out aiohttp for httpx? Already using httpx as a dependency, so I would like to use that.

Sure, I will do that in the next commit.

@UpstreamData
Copy link
Owner

MB, forgot to switch branch... will move this to main.

b-rowan
b-rowan reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

@b-rowan b-rowan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better start. Maybe move the updater to another module called "updater", and then the feed handling could be handled in different submodules? So directory structured like

  • pyasic
    • /updater
      • /bos.py
      • /whatsminer.py
      • /...

pyasic/miners/base.py Outdated Show resolved Hide resolved
b-rowan
b-rowan requested changes May 31, 2024
View reviewed changes
pyasic/ssh/braiins_os.py Outdated Show resolved Hide resolved
pyasic/updater/bos.py Outdated Show resolved Hide resolved
@1e9abhi1e10 1e9abhi1e10 marked this pull request as ready for review June 2, 2024 21:21
b-rowan
b-rowan requested changes Jun 4, 2024
View reviewed changes
pyasic/updater/__init__.py Outdated Show resolved Hide resolved
pyasic/updater/bos.py Outdated Show resolved Hide resolved
@b-rowan b-rowan merged commit 2ac118a into UpstreamData:master Jun 5, 2024
3 checks passed
@1e9abhi1e10 1e9abhi1e10 changed the title Add firmware update functionality Add firmware update functionality for BOS Miner Jun 5, 2024
This was referenced Jun 6, 2024
Merged
Merged
@1e9abhi1e10 1e9abhi1e10 deleted the update_firmware_1 branch July 30, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameshilliard jameshilliard jameshilliard left review comments

@b-rowan b-rowan b-rowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1e9abhi1e10 @b-rowan @UpstreamData @jameshilliard