-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#613: Custom PDF templates #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TickleThePanda
requested review from
a team,
jekabs-karklins,
charlieDurnsfordHollands,
vyshnavi1605 and
simonfernandes
and removed request for
a team,
charlieDurnsfordHollands and
vyshnavi1605
August 23, 2022 15:38
jekabs-karklins
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small comments, but looks good
jekabs-karklins
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new way of generating a proposal PDF based off a user officer input. This uses the custom template associated with a call as a template and renders with the proposal data data. To make it easier for the user officer to select the answers they want, the data is manipulated into a new object
answers
which is passed into the render, with subtemplates included in subobjects.Introduces a PDF factory picker so that the
PdfWorkflowManager
can choose between auto or custom templates. Keeps the old factory constructor option to thePdfWorkflowManager
to simplify the code for samples and visits.Moves a lot of the proposal PDF code into its own files to make discovery easier.
Motivation and Context
Refs UserOfficeProject/issue-tracker#613
How Has This Been Tested
Tested locally with the following and by adding new tests.
Proposal template
PDF template
Depends on
New template generation will not work until follow up PRs for UserOfficeProject/user-office-backend#716 and UserOfficeProject/user-office-frontend#988 have been merged but it will not break current template generation.
Tests included/Docs Updated?