Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added basic live actors data #45

Merged

Conversation

marius851000
Copy link
Contributor

While I still have some willpower remaining today (and it's 8AM...)

@marius851000 marius851000 force-pushed the partner_following branch 7 times, most recently from 7a70809 to 91955b3 Compare May 21, 2022 06:24
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
@marius851000
Copy link
Contributor Author

Updated. still don't know what an hander/sector is (but this is looked-up by the SkyTemple debugger). Also added a short comment describing the two classes.

@marius851000 marius851000 force-pushed the partner_following branch 3 times, most recently from d2438a1 to fc8ea65 Compare May 23, 2022 16:34
@theCapypara
Copy link
Contributor

Hanger and sector are names that come from debug outputs of the game.

A sector is a layer in script scenes. From my observations in RAM they are often not actually filled with the actual value but just -1 or 0 instead. I think they are just filled for for entities if a script command exists for their hanger that could remove sectors (meaning removing or hiding all entities on the layer.

Hanger are slots for scenes+scripts on the script engine.
1 is for enter scenes
2 is for acting scenes
3 is for sub scenes
4 is for talking sub scenes of enter scripts
5 is for special purposes iirc. eg. partner.ssb
6 is for talking sub scenes of sub scenes.

https://github.com/SkyTemple/skytemple-ssb-debugger/blob/4860a98317cd25d4af226a058e6158ffaa3e21f5/skytemple_ssb_debugger/controller/ground_state.py#L193

For details I'd recommend looking at the Ground State tab in the SkyTemple Debugger while the game has some scenes loaded.

@marius851000
Copy link
Contributor Author

Oops, totally forgot about this one. Will go back to that later today.

@marius851000
Copy link
Contributor Author

this is just rebasing I just did

headers/types/common/common.h Outdated Show resolved Hide resolved
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
headers/types/ground_mode/live_actor.h Outdated Show resolved Hide resolved
Copy link
Owner

@UsernameFodder UsernameFodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@UsernameFodder UsernameFodder merged commit 468be3a into UsernameFodder:master Jul 15, 2022
theCapypara added a commit to SkyTemple/c-of-time that referenced this pull request Sep 29, 2022
theCapypara added a commit to SkyTemple/c-of-time that referenced this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants