Bugfix for promisify error handling #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* errors now bubble up so as to be caught by client code * all errors now passed back to the client callback function * added explanatory comments for different error types * updated tests for the above changes
|
Once pushed to npm, we need to bump up the version in Slacker's |
* changed code back to throw ReferenceError and TypeError * added errorDetails to SlackServiceError * updated test and documentation in line with the above changes
Ustice
added a commit
that referenced
this pull request
Jan 28, 2015
Bugfix for promisify error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.