Reshuffle the 'legacy' attrs.xml and drawables.xml files

Keep values related to LegacyPlayerView in attrs_legacy_player_view.xml and put all values related to LegacyPlayerControlView back in their original locations. We plan to remove LegacyPlayerView (and attrs_legacy_player_view.xml) from media3, but will keep LegacyPlayerControlView - so the separation of the XML files needs to reflect this split. #minor-release PiperOrigin-RevId: 426406973
Utreon · Feb 21, 2022 · e42b51f · e42b51f
1 parent b320f7d
commit e42b51f
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 58 deletions.
diff --git a/library/ui/src/main/res/values/attrs.xml b/library/ui/src/main/res/values/attrs.xml
@@ -135,6 +135,33 @@
     <attr name="resize_mode"/>
   </declare-styleable>
 
+  <declare-styleable name="PlayerControlView">
+    <attr name="show_timeout"/>
+    <attr name="repeat_toggle_modes"/>
+    <attr name="show_rewind_button"/>
+    <attr name="show_fastforward_button"/>
+    <attr name="show_previous_button"/>
+    <attr name="show_next_button"/>
+    <attr name="show_shuffle_button"/>
+    <attr name="time_bar_min_update_interval"/>
+    <attr name="controller_layout_id"/>
+    <!-- DefaultTimeBar attributes -->
+    <attr name="bar_height"/>
+    <attr name="bar_gravity"/>
+    <attr name="touch_target_height"/>
+    <attr name="ad_marker_width"/>
+    <attr name="scrubber_enabled_size"/>
+    <attr name="scrubber_disabled_size"/>
+    <attr name="scrubber_dragged_size"/>
+    <attr name="scrubber_drawable"/>
+    <attr name="played_color"/>
+    <attr name="scrubber_color"/>
+    <attr name="buffered_color" />
+    <attr name="unplayed_color"/>
+    <attr name="ad_marker_color"/>
+    <attr name="played_ad_marker_color"/>
+  </declare-styleable>
+
   <declare-styleable name="StyledPlayerControlView">
     <attr name="show_timeout"/>
     <attr name="repeat_toggle_modes"/>

diff --git a/...y/ui/src/main/res/values/attrs_legacy.xml → ...n/res/values/attrs_legacy_player_view.xml b/...y/ui/src/main/res/values/attrs_legacy.xml → ...n/res/values/attrs_legacy_player_view.xml
@@ -51,31 +51,4 @@
     <attr name="played_ad_marker_color"/>
   </declare-styleable>
 
-  <declare-styleable name="PlayerControlView">
-    <attr name="show_timeout"/>
-    <attr name="repeat_toggle_modes"/>
-    <attr name="show_rewind_button"/>
-    <attr name="show_fastforward_button"/>
-    <attr name="show_previous_button"/>
-    <attr name="show_next_button"/>
-    <attr name="show_shuffle_button"/>
-    <attr name="time_bar_min_update_interval"/>
-    <attr name="controller_layout_id"/>
-    <!-- DefaultTimeBar attributes -->
-    <attr name="bar_height"/>
-    <attr name="bar_gravity"/>
-    <attr name="touch_target_height"/>
-    <attr name="ad_marker_width"/>
-    <attr name="scrubber_enabled_size"/>
-    <attr name="scrubber_disabled_size"/>
-    <attr name="scrubber_dragged_size"/>
-    <attr name="scrubber_drawable"/>
-    <attr name="played_color"/>
-    <attr name="scrubber_color"/>
-    <attr name="buffered_color" />
-    <attr name="unplayed_color"/>
-    <attr name="ad_marker_color"/>
-    <attr name="played_ad_marker_color"/>
-  </declare-styleable>
-
 </resources>
diff --git a/library/ui/src/main/res/values/drawables.xml b/library/ui/src/main/res/values/drawables.xml
@@ -23,6 +23,21 @@
   <drawable name="exo_notification_stop">@drawable/exo_icon_stop</drawable>
   <drawable name="exo_notification_small_icon">@drawable/exo_icon_circular_play</drawable>
 
+  <drawable name="exo_controls_play">@drawable/exo_icon_play</drawable>
+  <drawable name="exo_controls_pause">@drawable/exo_icon_pause</drawable>
+  <drawable name="exo_controls_next">@drawable/exo_icon_next</drawable>
+  <drawable name="exo_controls_previous">@drawable/exo_icon_previous</drawable>
+  <drawable name="exo_controls_fastforward">@drawable/exo_icon_fastforward</drawable>
+  <drawable name="exo_controls_rewind">@drawable/exo_icon_rewind</drawable>
+  <drawable name="exo_controls_repeat_all">@drawable/exo_icon_repeat_all</drawable>
+  <drawable name="exo_controls_repeat_off">@drawable/exo_icon_repeat_off</drawable>
+  <drawable name="exo_controls_repeat_one">@drawable/exo_icon_repeat_one</drawable>
+  <drawable name="exo_controls_shuffle_off">@drawable/exo_icon_shuffle_off</drawable>
+  <drawable name="exo_controls_shuffle_on">@drawable/exo_icon_shuffle_on</drawable>
+  <drawable name="exo_controls_fullscreen_enter">@drawable/exo_icon_fullscreen_enter</drawable>
+  <drawable name="exo_controls_fullscreen_exit">@drawable/exo_icon_fullscreen_exit</drawable>
+  <drawable name="exo_controls_vr">@drawable/exo_icon_vr</drawable>
+
   <drawable name="exo_styled_controls_play">@drawable/exo_ic_play_circle_filled</drawable>
   <drawable name="exo_styled_controls_pause">@drawable/exo_ic_pause_circle_filled</drawable>
   <drawable name="exo_styled_controls_next">@drawable/exo_ic_skip_next</drawable>

diff --git a/library/ui/src/main/res/values/drawables_legacy.xml b/library/ui/src/main/res/values/drawables_legacy.xml