-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor into vba-test #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 27, 2018
Ok, this is ready to merge, here is a short upgrade guide:
Some of the previous matchers will most likely be added back at some point in the future, but for now I'm happy with the simplified API. |
Co-authored-by: Vitosh Academy <Vitosh@users.noreply.github.com> Co-authored-by: Kevin Conner <kevin.r.conner@gmail.com>
This was referenced Aug 28, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vba-test is a new approach to VBA-TDD that simplifies the API and allows for future work on more powerful assertion messages and integration with vba-blocks.
You can view a mockup of the new API here: vba-test/readme
The underlying changes are a complete rename and refactor, although the approach is generally already in use in v2.0.0-beta (with an evented suite). It may be a burdensome upgrade to map
.Expect(A).ToEqual B
to.IsEqual A, B
, but I think it will be a welcome simplification and opens up new avenues in the future.Closes #11
Closes #12
Closes #13
Closes #16
Closes #17
Closes #22