Moved ResponseContextStructure to OJP_RequestSupport.xsd #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OJP_Places.xsd was not well-formed, because it used ResponseContextStructure without including it. Moved ResponseContextStructure from OJP_JourneySupport.xsd to OJP_RequestSupport.xsd, as it is a general structure and not only for journeys. Added includes of OJP_RequestSupport into several files.
|
Could you all please check, whether this branch validates in your frameworks? |
ue71603
approved these changes
Oct 24, 2020
sgrossberndt
approved these changes
Nov 11, 2020
There was a problem hiding this comment.
I just cherry-picked these on top of #115 and the validation of the examples does still work.
In general we should think whether these singular inclusions of xsds in others make sense or if we should add a OJP_All.xsd or the like which includes all sub-XSDs, but that is rather not the scope of this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OJP_Places.xsd was not well-formed, because it used ResponseContextStructure without including it. Moved ResponseContextStructure from OJP_JourneySupport.xsd to OJP_RequestSupport.xsd, as it is a general structure and not only for journeys. Added includes of OJP_RequestSupport into several files.