Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operators to PlaceResultStructure and ResponseContext, allow multiple per ServiceGroup #220

Merged
merged 39 commits into from
Jan 20, 2023
Merged

Add operators to PlaceResultStructure and ResponseContext, allow multiple per ServiceGroup #220

merged 39 commits into from
Jan 20, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Jul 25, 2022

… PlaceResult and in Service for ALTERNATIVE MODEs

This allows to tell which TAXI or VEHICLE SHARING operations are active at a place or in a ContinuousLeg.

fixes: #212

@ue71603 ue71603 added enhancement New feature or request documentation labels Jul 25, 2022
@ue71603 ue71603 added this to the v2.0 milestone Jul 25, 2022
@ue71603 ue71603 mentioned this pull request Jul 25, 2022
Closed
@markus-meier-sbb
Copy link

IMHO this addition is useful and necessary so that operator data can be properly included for the new modes like taxi, sharing, etc.. Without this addition, it would be hard to include all potential operators (e.g. all taxi companies) for such legs.

skinkie
skinkie reviewed Aug 8, 2022
View reviewed changes
OJP/OJP_Places.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Aug 8, 2022
View reviewed changes
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 requested a review from skinkie September 1, 2022 11:55
herlitze
herlitze previously approved these changes Oct 2, 2022
View reviewed changes
skinkie
skinkie reviewed Oct 18, 2022
View reviewed changes
OJP/OJP_RequestSupport.xsd Outdated Show resolved Hide resolved
skinkie
skinkie previously approved these changes Oct 18, 2022
View reviewed changes
herlitze
herlitze previously approved these changes Oct 18, 2022
View reviewed changes
skinkie
skinkie reviewed Oct 18, 2022
View reviewed changes
OJP/OJP_RequestSupport.xsd Outdated Show resolved Hide resolved
@skinkie skinkie dismissed stale reviews from herlitze and themself via ff625e9 October 18, 2022 07:57
herlitze
herlitze previously approved these changes Oct 18, 2022
View reviewed changes
@skinkie skinkie self-requested a review October 18, 2022 07:58
skinkie
skinkie previously approved these changes Oct 18, 2022
View reviewed changes
@ue71603 ue71603 dismissed stale reviews from skinkie and herlitze via 08e9a6e October 18, 2022 12:33
skinkie
skinkie reviewed Oct 18, 2022
View reviewed changes
OJP/OJP_Places.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Oct 18, 2022
View reviewed changes
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Oct 18, 2022
View reviewed changes
OJP/OJP_RequestSupport.xsd Outdated Show resolved Hide resolved
trurlurl
trurlurl previously approved these changes Dec 30, 2022
View reviewed changes
herlitze
herlitze reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@herlitze herlitze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there still a parameter missing in the TripRefine request to select a specific sharing provider when requesting a specific trip with that provider?

@ue71603
Copy link
Contributor Author

ue71603 commented Jan 17, 2023

Isn't there still a parameter missing in the TripRefine request to select a specific sharing provider when requesting a specific trip with that provider?

@herlitze Is now addressed here: #298 . So I gues swe can process this one without dealing with that aspect?

skinkie
skinkie reviewed Jan 17, 2023
View reviewed changes
OJP/OJP_Common.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jan 17, 2023
View reviewed changes
OJP/OJP_Common.xsd Outdated
@@ -87,6 +87,11 @@
<xs:documentation>Reference to an Operator ([TMv6] company providing public transport services.) </xs:documentation>
</xs:annotation>
</xs:element>
<xs:complexType name="OperatorRelStructure">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be operatorRefs_RelStructure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

skinkie
skinkie reviewed Jan 17, 2023
View reviewed changes
OJP/OJP_RequestSupport.xsd Outdated
@@ -166,11 +166,28 @@
<xs:element name="Place" type="PlaceStructure" maxOccurs="unbounded"/>
</xs:sequence>
</xs:complexType>
<xs:complexType name="OperatorsStructure">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one operators_RelStructure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

skinkie
skinkie previously approved these changes Jan 17, 2023
View reviewed changes
trurlurl
trurlurl previously approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@trurlurl trurlurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the newly introduced _Rel, the use of underscore and Rel stands out quite uniquely. But I gueass the others understand meaning and usefulness of it better than me.

@skinkie
Merge branch 'changes_for_v1.1' into Operators_updated
f177268 
# Conflicts:
#	docs/generated/index.html
@skinkie skinkie dismissed stale reviews from trurlurl and themself via f177268 January 19, 2023 15:59
@skinkie
Merge branch 'changes_for_v1.1' into Operators_updated
6419c2e 
# Conflicts:
#	OJP/OJP_Places.xsd
#	docs/generated/index.html
trurlurl
trurlurl previously approved these changes Jan 20, 2023
View reviewed changes
AndreasAtSBB
AndreasAtSBB previously approved these changes Jan 20, 2023
View reviewed changes
Copy link

@AndreasAtSBB AndreasAtSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@skinkie skinkie dismissed stale reviews from AndreasAtSBB and trurlurl via e7dab20 January 20, 2023 10:55
AndreasAtSBB
AndreasAtSBB approved these changes Jan 20, 2023
View reviewed changes
Copy link

@AndreasAtSBB AndreasAtSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes OK.

@skinkie skinkie merged commit 1f886c2 into changes_for_v1.1 Jan 20, 2023
@skinkie skinkie deleted the Operators_updated branch January 20, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herlitze herlitze herlitze left review comments

@AndreasAtSBB AndreasAtSBB AndreasAtSBB approved these changes

@trurlurl trurlurl trurlurl approved these changes

@skinkie skinkie skinkie approved these changes

@sgrossberndt sgrossberndt sgrossberndt left review comments

@rcavaliere rcavaliere Awaiting requested review from rcavaliere

@kgrimme kgrimme Awaiting requested review from kgrimme

@markus-meier-sbb markus-meier-sbb Awaiting requested review from markus-meier-sbb

Assignees
No one assigned
Labels
doc updated enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ue71603 @markus-meier-sbb @sgrossberndt @skinkie @herlitze @trurlurl @AndreasAtSBB