Define VATRate as percentage instead of enum #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinkie
reviewed
Sep 21, 2022
OJP/OJP_FareSupport.xsd
Outdated
| @@ -273,9 +261,9 @@ | |||
| <xs:documentation>iso 4217 currency code, e.g. EUR for Euro or GBP for Pound Sterling </xs:documentation> | |||
| </xs:annotation> | |||
| </xs:element> | |||
| <xs:element name="VatRate" type="VatRateEnumeration" minOccurs="0"> | |||
| <xs:element name="VatRate" type="xs:decimal" minOccurs="0"> | |||
There was a problem hiding this comment.
Given this being a percentage. Something like 0-100 as limits?
There was a problem hiding this comment.
@skinkie in Siri we have a percentage and it was also an xsd:decimal. I already had a class prepared. and there is one in DATEX II, but I thought best not to create new discrepancies. What do you think?
siri_journey-v2.0.xsd
<xsd:element name="Percentage" type="xsd:decimal" minOccurs="0"> <xsd:annotation> <xsd:documentation>Percentage along link that VEHICLE has travelled.</xsd:documentation> </xsd:annotation> </xsd:element>
DATEXIISchema_1_0_1_0.xsd:
<xs:simpleType name="Percentage">
xs:annotation
xs:documentationA measure of percentage.</xs:documentation>
</xs:annotation>
<xs:restriction base="D2LogicalModel:Float"/>
</xs:simpleType>
|
percentage will be done |
skinkie
previously approved these changes
Oct 18, 2022
sgrossberndt
force-pushed
the
VATRate_as_decimal
branch
from
5c0525c
to
dd41c9c
Compare
sgrossberndt
changed the title
sgrossberndt
force-pushed
the
VATRate_as_decimal
branch
from
166db5f
to
1e513a1
Compare
sgrossberndt
approved these changes
Oct 19, 2022
skinkie
approved these changes
Oct 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #225