Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend definition of entitlement products #229

Merged
merged 5 commits into from
Oct 19, 2022

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Aug 11, 2022

The FarePassengerStructure could contain multiple EntitlementProductRefs before, which did not contain much information, just the ID of the entitlement product. With this change the FarePassengerStructure may contain a EntitlementProductList instead consisting of EntitlementProducts, which allows to define for each entitlement product:

  • FareAuthorityRef
  • EntitlementProductRef
  • ValidityPeriod
  • EntitlementProductName

This improves the EntitlementProduct definition to match elements like ZonesAlreadyPaid.

Fixes #222

@ue71603 ue71603 added enhancement New feature or request documentation labels Aug 11, 2022
@ue71603 ue71603 added this to the v2.0 milestone Aug 11, 2022
OJP/OJP_FareSupport.xsd Outdated Show resolved Hide resolved
OJP/OJP_FareSupport.xsd Show resolved Hide resolved
Copy link
Contributor

@sgrossberndt sgrossberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is meant by Improving Entitlement Product to match others. Which "others"?

OJP/OJP_FareSupport.xsd Show resolved Hide resolved
OJP/OJP_FareSupport.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 changed the title Improving Entitlement Product to match others Improving Entitlement Product to match elements like ZonesAlreadyPaid Sep 15, 2022
@ue71603
Copy link
Contributor Author

ue71603 commented Sep 15, 2022

What is meant by Improving Entitlement Product to match others. Which "others"?

updated title and description of pr

sgrossberndt
sgrossberndt previously approved these changes Sep 28, 2022
@sgrossberndt sgrossberndt changed the title Improving Entitlement Product to match elements like ZonesAlreadyPaid Extend definition of entitlement products Sep 28, 2022
@sgrossberndt sgrossberndt merged commit b277052 into changes_for_v1.1 Oct 19, 2022
@sgrossberndt sgrossberndt deleted the Improving_Entitlement_Product branch October 19, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc updated enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants