-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend definition of entitlement products #229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrossberndt
requested changes
Aug 12, 2022
sgrossberndt
requested changes
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is meant by Improving Entitlement Product to match others
. Which "others"?
ue71603
changed the title
Improving Entitlement Product to match others
Improving Entitlement Product to match elements like ZonesAlreadyPaid
Sep 15, 2022
updated title and description of pr |
sgrossberndt
force-pushed
the
Improving_Entitlement_Product
branch
from
September 28, 2022 08:16
21b03a4
to
2ef1bdb
Compare
sgrossberndt
previously approved these changes
Sep 28, 2022
sgrossberndt
changed the title
Improving Entitlement Product to match elements like ZonesAlreadyPaid
Extend definition of entitlement products
Sep 28, 2022
sgrossberndt
force-pushed
the
Improving_Entitlement_Product
branch
from
October 12, 2022 09:05
208d9ca
to
4a7bd67
Compare
sgrossberndt
approved these changes
Oct 12, 2022
herlitze
approved these changes
Oct 18, 2022
skinkie
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FarePassengerStructure
could contain multipleEntitlementProductRef
s before, which did not contain much information, just the ID of the entitlement product. With this change theFarePassengerStructure
may contain aEntitlementProductList
instead consisting ofEntitlementProduct
s, which allows to define for each entitlement product:This improves the
EntitlementProduct
definition to match elements likeZonesAlreadyPaid
.Fixes #222