-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AccessFeatureStatus on PathLink #238
Conversation
I approved it since I'm ok with it, but won't be against a "partiallyAvailable" if somebody thinks that it is useful (double door with one broken, etc.) ... but I recognise that it is often difficult to use |
I think the questions raised in the first comment should be answered before closing this PR - what are your opinions regarding |
Documentation regarding the PathLink part is up do date so far. |
Will discussed the 25.10. |
André: Can the non-working in the situation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SIRI contains
- an
EquipmentStatusEnumeration
insiri/ifopt/ifopt_equipment-v0.3.xsd
with valuesunknown
,available
,notAvailable
- a
FacilityStatusEnumeration
insiri/siri_model/siri_facility-v2.0.xsd
with valuesunknown
,available
,notAvailable
,partiallyAvailable
,added
,removed
As both don't completely fit I guess its fine to introduce our own enumeration. Or should we use one from SIRI? If we define our own enumeration - is "EQUIPMENT" the correct term here or should it rather be AccessFeatureStatusEnumeration
?
@sgrossberndt |
I hesitated adding a AccessFeatureRef (siri/ifopt/EquipmentRefStructure). I didn't add it yet because the situation information relating to the Equipment can be directly attached to the PathLink (SituationFullRef). |
André is doing another small change, then ready for review. |
bcc7485
to
5e15719
Compare
Added Feasibility, AccessFeatureStatusText, SituationFullRef
resolved merge problem
thanks André
f4886eb
to
e51fbf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
@@ -471,12 +476,17 @@ | |||
</xs:annotation> | |||
</xs:element> | |||
<xs:group ref="OperatingDaysGroup" minOccurs="0"/> | |||
<xs:group ref="TripStatusGroup" minOccurs="0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This merge moved the position of TripStatusGroup. Was this on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please report all collateral damage due to manual merging to @ue71603
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgrossberndt and the fact that this change was not picked up by CI shows we lack examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it on purpose. In all other examples Situations were the last before Extension. It thought it was a mistake during the change in Situations. Certainly I should not have done it in this PR if that was not the case (as it seems), but from homogenity, I think it is right. I can undo it in an additional PR if you like @sgrossberndt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, don't undo it. But it should not have been part of this PR but handled separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know... I only did it, because I thought it was messed up during the merge by me or during the creation of the PR. Should have checked.
AccessFeatureStatus on a PathLink to indicate a broken access equipment.
#194 asks for data to tell whether, e.g., an elevator is broken, but to nevertheless show the route so that the passenger knows that this route would exist but is currently not feasible.
EquipmentStatusEnumeration has been added from NeTEx to indicate the status of an access equipment. The following would indicate that the elevator is broken:
PathLink.AccessFeatureStatus: notAvailable (new)
PathLink.AccessFeatureType: elevator
The broken elevator makes the complete TransferLeg unfeasible - this should be flagged in the TransferLeg (e.g., TransferLeg.Feasibility : accessEquipmentOutOfService) or/and at the level of the Trip.
What solution would you prefer?
To also handle the case that the TranferLeg is not feasible due to a SituationFull (can that happen?), this could be indicated by:
TransferLeg.Feasibility: seeSituations
Replaces #235