Allow level information on PathLinks #239
Conversation
There was a problem hiding this comment.
Instead of repeating Level in From->LevelPublicCode and From->LevelName and having From->Id what about naming From FromLevel and To ToLevel and thus having FromLevel->PublicCode, FromLevel->Name, FromLevel->Id instead? This PublicCode part would be more consistent with the just merged simplified element names
| @@ -743,6 +743,38 @@ | |||
| <xs:documentation>Number how often the access feature occurs in this PathLink</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:element> | |||
| <xs:element name="From" type="PathLinkEndStructure" minOccurs="0"> | |||
There was a problem hiding this comment.
This structure makes it possible to only supply a From, but no To. Maybe add a group consisting of exactly one From and one To element and give the group minOccurs="0" instead?
There was a problem hiding this comment.
@sgrossberndt The structure also makes it possible to supply only a To. But wouldn't that be welcome? - When giving directions, it is usually sufficient to provide information only for the To (for instance the PublicCode of the target level when using an elevator).
Regarding your previous comment: The idea of the Id was not to point to a Level, but more generally to an element at the end of a PathLink - for instance a NeTEx AccessSpace or an EquipmentPlace (this would later allow for retrieving additional information, e.g., the coordinates of the EquipmentPlace of the elevator). Thus, ToLevel->Id would not be what was intended. That said, I think it is better to stay with the proposed solution. What do you think?
There was a problem hiding this comment.
OK. I think the change requested by @sgrossberndt is obsolete, see the first "show comment" in the conversation tab.
|
Documentation updated accordingly. |
|
We will use kilograms. Also use float |
Improved the descriptions according to the discussion between André and Stephan.
sgrossberndt
dismissed stale reviews from skinkie, Aurige, and trurlurl
via
c751458
sgrossberndt
force-pushed
the
AllowsLevelInformationOnPathLinks
branch
from
4d95e41
to
c751458
Compare
Allows for level information on PathLinks. This PR responds to #145.
#145 asks for more data to tell a passenger, for instance, to use an elevator leading from level "A" to level "U1". This is achieved by adding FromLevel, ToLevel, LevelNameStructure.
Typical attributes useful for guidance in that kind of use cases (example):
PathLink.Transition: down
PathLink.AccessFeatureType: elevator
PathLink.FromLevel.PublicCode: A (new)
PathLink.ToLevel.PublicCode: U1 (new)
Two other PRs related to this will follow soon - dealing with real-time information about access equipment (#194) and additional accessiblity information.
Replaces #234