Expanding PathGuidance #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ue71603
requested review from
skinkie,
Aurige,
sgrossberndt,
dirkweisser,
rcavaliere,
herlitze,
kgrimme,
normanoffel,
JonaVBB,
trurlurl,
AndreasAtSBB and
AlexandreIglesiasCityway
herlitze
reviewed
Nov 24, 2022
herlitze
reviewed
Nov 24, 2022
|
Needs some advocacy |
ue71603
commented
Nov 24, 2022
ue71603
commented
Nov 24, 2022
ue71603
commented
Nov 24, 2022
ue71603
commented
Nov 24, 2022
ue71603
commented
Nov 24, 2022
ue71603
commented
Dec 5, 2022
Aurige
reviewed
Dec 16, 2022
ue71603
commented
Dec 16, 2022
Aurige
previously approved these changes
Dec 16, 2022
* added PlaceSortingGroup to PlaceParamStructure * Update OJP/OJP_Places.xsd * problem message for unsupported sorting method Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Stephan Großberndt <s.grossberndt@sidebysite.de> Co-authored-by: Stefan de Konink <stefan@konink.de> Co-authored-by: Malte Herlitze <herlitze@mentz.net>
* Necessary low level elements for User Preferences No UserPreference for the time being. New optimisation methods, walking and cycling profile and includeAlternativeOptions all for Trips
|
@sgrossberndt broke this one too... |
# Conflicts: # docs/generated/index.html
sgrossberndt
force-pushed
the
changes_for_v1.1
branch
from
cf663d0
to
0e21b03
Compare
sgrossberndt
force-pushed
the
PathGuidance
branch
from
e5ac9ba
to
916bf3d
Compare
trurlurl
previously approved these changes
Jan 19, 2023
AndreasAtSBB
previously approved these changes
Jan 20, 2023
|
Important: validate that the merge went correct! |
skinkie
reviewed
Jan 20, 2023
skinkie
reviewed
Jan 20, 2023
# Conflicts: # OJP/OJP_Trips.xsd # docs/generated/index.html
skinkie
reviewed
Jan 20, 2023
trurlurl
approved these changes
Jan 20, 2023
herlitze
reviewed
Jan 20, 2023
| </xs:annotation> | ||
| </xs:element> | ||
| <xs:element name="TurnAction" type="TurnActionEnumeration" minOccurs="0"> | ||
| <xs:annotation> | ||
| <xs:documentation>the range of alternative turns that can be described.</xs:documentation> | ||
| <xs:documentation>The range of alternative turns that can be described.</xs:documentation> |
There was a problem hiding this comment.
I think possible might be more fitting?
"The range of possible turns that can be described."
| </xs:enumeration> | ||
| <xs:enumeration value="continue"> | ||
| <xs:annotation> | ||
| <xs:documentation>continue on the same street/road/path.</xs:documentation> |
| </xs:enumeration> | ||
| <xs:enumeration value="keep"> | ||
| <xs:annotation> | ||
| <xs:documentation>keep going on the same street/road/path.</xs:documentation> |
| </xs:restriction> | ||
| </xs:simpleType> | ||
| <xs:simpleType name="TurnActionEnumeration"> | ||
| <xs:annotation> | ||
| <xs:documentation>the range of alternative turns that can be described</xs:documentation> | ||
| <xs:documentation>The range of alternative turns that can be described</xs:documentation> |
There was a problem hiding this comment.
I think possible might be more fitting?
"The range of possible turns that can be described."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PathGuidance is now strenghened and better explained.
Fixes: #248
On purpose no accessibility changes were incorporated. Those come from other PR.
We need to discuss keep & continue. There I find the explantions a bit week.
Also it is clear, that the annotations in enum problem applies also here.
@herlitze I think it is important, that you have a look at it.