Rename ExchangePointsResult element #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ue71603
previously approved these changes
Jan 15, 2023
skinkie
approved these changes
Jan 17, 2023
* LineInformation Request and Response Specially for the shape of the line. * Travis CI update [skip ci] * switched shape to gml:LineString * remove Probability * Travis CI update [skip ci] * typo corrected * remedy for Stefans itches ;-) * update xsd * Travis CI update [skip ci] * simplyfy siri import * gml removed, error fixed, example added * Update schema-collection.xml * Lint and update documentation tables * Lint and update documentation tables * Better name for the elemente RouteGeometry for simplicities sake, I would like to still kee it a LinkProjectionStructure * update example * Lint and update documentation tables * LinkProjectionStructure -> LinearShapeStructure * fixed error during rebasing * Lint and update documentation tables * don't mix changes ...and I think I won't change it afterwards at all. * Lint and update documentation tables * Update OJP/OJP_Requests.xsd * Update OJP/OJP_Common.xsd * Lint and update documentation tables * Update OJP/OJP_Lines.xsd * Lint and update documentation tables Co-authored-by: Travis CI User <travis@example.org> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Stefan de Konink <stefan@konink.de>
skinkie
previously approved these changes
Jan 19, 2023
commit 7b577f1 Author: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Date: Sun Jan 15 16:19:55 2023 +0000 Lint and update documentation tables commit e0d210f Author: trurlurl <82838870+trurlurl@users.noreply.github.com> Date: Sun Jan 15 17:11:24 2023 +0100 Improved naming consistency
|
Manually merged; fc1981c |
skinkie
previously approved these changes
Jan 19, 2023
skinkie
previously approved these changes
Jan 19, 2023
sgrossberndt
changed the title
|
@sgrossberndt need help; this went very wrong. |
|
I'll reset this branch and pull request to the former state |
skinkie
force-pushed
the
small_corrections_exchangepoints
branch
from
f8f6c6a
to
a8f6598
Compare
# Conflicts: # docs/generated/index.html
|
or.. you do this :-D |
Needed to find exactly how. |
sgrossberndt
force-pushed
the
changes_for_v1.1
branch
from
cf663d0
to
0e21b03
Compare
|
Stefan: Needs to be reviewed very carefully. |
# Conflicts: # OJP/OJP_Trips.xsd # docs/generated/index.html
|
Please make sure that the merge is correct before accepting. |
skinkie
reviewed
Jan 20, 2023
skinkie
reviewed
Jan 20, 2023
OJP/OJP_Trips.xsd
Outdated
| @@ -824,6 +824,7 @@ | |||
| <xs:documentation>A list of references to SITUATIONs.</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:element> | |||
| <xs:element name="SituationFullRef" type="SituationFullRefStructure" minOccurs="0" maxOccurs="unbounded"/> | |||
There was a problem hiding this comment.
@sgrossberndt This comes from somewhere... but is likely correct.
There was a problem hiding this comment.
No, it is not correct. SituationFullRefs replaced SituationFullRef
There was a problem hiding this comment.
sgrossberndt
previously requested changes
Jan 20, 2023
OJP/OJP_Trips.xsd
Outdated
| @@ -824,6 +824,7 @@ | |||
| <xs:documentation>A list of references to SITUATIONs.</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:element> | |||
| <xs:element name="SituationFullRef" type="SituationFullRefStructure" minOccurs="0" maxOccurs="unbounded"/> | |||
There was a problem hiding this comment.
No, it is not correct. SituationFullRefs replaced SituationFullRef
skinkie
reviewed
Jan 20, 2023
skinkie
previously approved these changes
Jan 20, 2023
skinkie
approved these changes
Jan 20, 2023
herlitze
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames the result elements in the
ExchangePointsResponseGroupfromPlacetoExchangePointsResult. The former namePlacewas probably a copy-paste-error which already existed in OJP 1.0 and was not found until now.It also improves the naming consistency by renaming the structures
ExchangePointResponseContexttoExchangePointsResponseContextExchangePointProblemStructuretoExchangePointsProblemStructure