Allow NumberOfResultsBefore or NumberOfResultsAfter to be 0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this moment the user is forced to select at least one result after even if the user is only interested in one result before. This commit allows to specify a 0 value, but also allow to omit the element, the system may infer the desired value.
|
Fixes #24 |
|
Please amend the first commit so we have only one commit for this change in the history |
|
@sgrossberndt could you tell me what I have to amend? You mean you want to 'rebase fast-forward'? |
pvgrumbkow
approved these changes
Feb 26, 2019
sgrossberndt
approved these changes
Feb 26, 2019
herlitze
pushed a commit
that referenced
this pull request
Jan 29, 2020
* Allow NumberOfResultsBefore or NumberOfResultsAfter to be 0 At this moment the user is forced to select at least one result after even if the user is only interested in one result before. This commit allows to specify a 0 value, but also allow to omit the element, the system may infer the desired value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment the user is forced to select at least one result after even if the user is only interested in one result before.
This commit allows to specify a 0 value, but also allow to omit the element, the system may infer the desired value.