Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path to xsd corrected in xml examples #314

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Jan 24, 2023

After the reorgnanisation the relative paths to the xsd in the xml were incorrect. This is now corrected.

@ue71603 ue71603 added the bug Something isn't working label Jan 24, 2023
@ue71603 ue71603 added this to the v2.0 milestone Jan 24, 2023
Copy link
Contributor

@skinkie skinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still not 'correct'.

@ue71603 ue71603 changed the title xml reference xsd now correctly Path to xsd corrected in xml examples Jan 24, 2023
@ue71603
Copy link
Contributor Author

ue71603 commented Jan 24, 2023

I think this is still not 'correct'.

they validate in XML Spy. What makes you unhappy?

@skinkie
Copy link
Contributor

skinkie commented Jan 24, 2023

What do you think happens when we migrate to the upstream SIRI branch...

@ue71603
Copy link
Contributor Author

ue71603 commented Jan 24, 2023

nothing hopefully. It will link to the same place in the local copy, I guess.

Copy link

@AndreasAtSBB AndreasAtSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File path fixed.

@skinkie skinkie merged commit fc28dc0 into changes_for_v1.1 Jan 27, 2023
@skinkie skinkie deleted the correct-the-reference-of-the-xsd-in-examples.-Will-help branch March 14, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants