Add a parameter to FareResult indicating whether it was estimated #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ue71603
requested review from
skinkie,
Aurige,
sgrossberndt,
herlitze,
normanoffel and
trurlurl
trurlurl
reviewed
Mar 2, 2023
now corrected. |
trurlurl
previously approved these changes
Mar 3, 2023
skinkie
previously approved these changes
Mar 9, 2023
sgrossberndt
requested changes
Mar 9, 2023
ue71603
commented
Mar 9, 2023
|
What does "estimated" mean, how to react to this as a receiver? |
sgrossberndt
previously approved these changes
Mar 9, 2023
|
@sgrossberndt Improve documentation in XSD or in specification. The idea is: "Estimated can mean different things: The price may vary e.g. depending on age, PassangerCategory, TravelClass, EntitlementProducts). It may also mean, that the fare structure that the fare service uses is not really accurate or that other factors like time a shared car is used, may play into the price. Usually a client should then should present the price as approximate and probably lower limit of the real price." |
trurlurl
previously approved these changes
Mar 9, 2023
skinkie
previously approved these changes
Mar 9, 2023
sgrossberndt
dismissed stale reviews from skinkie, trurlurl, and themself
via
5db36b9
sgrossberndt
changed the title
sgrossberndt
approved these changes
Mar 10, 2023
skinkie
approved these changes
Mar 13, 2023
|
The SBB eMail server is too slow 😊
Von: Stefan de Konink ***@***.***>
Gesendet: Montag, 13. März 2023 19:28
An: VDVde/OJP ***@***.***>
Cc: Günter Matthias (IT-PTR-EXT-EXT2 - Extern) ***@***.***>; Author ***@***.***>
Betreff: Re: [VDVde/OJP] Add a parameter to FareResult indicating whether it was estimated (PR #324)
@skinkie approved this pull request.
—
Reply to this email directly, view it on GitHub<#324 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFY25DWKJU6X7I5K7J3YHYLW35RKVANCNFSM6AAAAAAVNPECXE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases the FareResult is only an estimate. We should be able to communicate this.