Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ProtoProduct into FareProductStructure #60

Merged
merged 3 commits into from
Apr 17, 2020

Conversation

pvgrumbkow
Copy link
Contributor

A proto product is a fare product, which shall not be shown to the user directly. Instead it carries fare product related information, which can be processed further. Can be used for tariffing in a distributed environment, where OJP services can deliver only parts of a fare product.

A proto product is a fare product, which shall not be shown to the user directly. Instead it carries fare product related information, which can be processed further. Can be used for tariffing in a distributed environment, where OJP services can deliver only parts of a fare product.
@pvgrumbkow
Copy link
Contributor Author

Solves issue #51

@pvgrumbkow pvgrumbkow added this to the v1.1 milestone Jan 30, 2020
@pvgrumbkow pvgrumbkow added the enhancement New feature or request label Jan 30, 2020
@@ -238,6 +237,11 @@
</xs:annotation>
</xs:element>
<xs:group ref="FareAuthorityGroup"/>
<xs:element name="ProtoProduct" type="xs:boolean" default="false" minOccurs="0">
<xs:annotation>
<xs:documentation>Is the product a proto product? If yes, it should not be shown to the user directly. Instead a proto product transports fare product information, which usually has to be processed further. Default is false.</xs:documentation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend by

Can be used for tariffing in a distributed environment, where OJP services can deliver only parts of a fare product.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall I explain, why a proto fare product can be sensible in a distributed environment or shall we discard the "where ..." part of the sentence?

Included references to EU-Spirit.
Copy link
Contributor

@sgrossberndt sgrossberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this product a proto product? Default is false. If yes, it should not be shown to the user. In a distributed environment (e.g. EU-Spirit) partial systems may generate incomplete product information (proto product), which has to be be processed further and combined with other information before it is a complete fare product and can be shown to the user. See https://eu-spirit.eu/

skinkie
skinkie previously approved these changes Apr 17, 2020
herlitze
herlitze previously approved these changes Apr 17, 2020
@pvgrumbkow pvgrumbkow dismissed stale reviews from herlitze and skinkie via ecc463a April 17, 2020 08:43
@pvgrumbkow pvgrumbkow merged commit b73f79e into changes_for_v1.1 Apr 17, 2020
@pvgrumbkow pvgrumbkow deleted the SilentFareProducts branch April 17, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants