Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LineId at boarding/alighting #61

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Conversation

pvgrumbkow
Copy link
Contributor

Added LineIdAtBoarding in LegBoardStructure and LineIdAtAlighting in LegAlightStructure. This way, an arbitrary identifier for a service at boarding and alighting can be transported, which is independent from JourneyRef. This can be used in distributed environments in order to recognize, that two systems refer the same line/service while they still use their own internal references.

Added LineIdAtBoarding in LegBoardStructure and LineIdAtAlighting in LegAlightStructure. This way, an arbitrary identifier for a service at boarding and alighting can be transported, which is independent from JourneyRef. This can be used in distributed environments in order to recognize, that two systems refer the same line/service while they still use their own internal references.
@pvgrumbkow pvgrumbkow added the enhancement New feature or request label Jan 30, 2020
@pvgrumbkow pvgrumbkow added this to the v1.1 milestone Jan 30, 2020
@pvgrumbkow
Copy link
Contributor Author

Solves issue #48

OJP_Trips.xsd Outdated
@@ -548,6 +547,11 @@
</xs:sequence>
</xs:complexType>
</xs:element>
<xs:element name="LineIdAtBoarding" type="xs:normalizedString" minOccurs="0">
<xs:annotation>
<xs:documentation>Identifier of the boarded line/service at the boarding. This is not a reference. This identifier is used to recognize in a distributed environment, that two systems refer to the same line service (or service) while using their own internal references.</xs:documentation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifier of the boarded line/service during boarding. This is not a reference. This identifier is used to recognize the line in a distributed environment (two systems referring to the same line service (or service) while using their own internal references).

With the current (slightly changed) documentation text it is still not clear to me what to expect in/from this element. Maybe enhance it a bit more?

What is meant by "line service (or service)"?

OJP_Trips.xsd Outdated
@@ -582,6 +586,11 @@
</xs:sequence>
</xs:complexType>
</xs:element>
<xs:element name="LineIdAtAlighting" type="xs:normalizedString" minOccurs="0">
<xs:annotation>
<xs:documentation>Identifier of the alighted line/service at the alighting. This is not a reference. This identifier is used to recognize in a distributed environment, that two systems refer to the same line service (or service) while using their own internal references.</xs:documentation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifier of the alighted line/service during alighting. This is not a reference. This identifier is used to recognize the line in a distributed environment (two systems referring to the same line service (or service) while using their own internal references).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, is your proposal to take over your edited text? "Line service (or service)" sounds really weird, simply "service" would be correct.

LineIdAtBoarding and LineIdAtAlighting are now called DistributorInterchangeId and FeederInterchangeId respectively. Corresponding annotations include now references to EU-Spirit.
@pvgrumbkow pvgrumbkow merged commit 5b8aa1f into changes_for_v1.1 Apr 17, 2020
@pvgrumbkow pvgrumbkow deleted the LineIDAtBoardAlight branch April 17, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants