Service / mode extension #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the Extension to Service and Modes
* Extenion in DatenServiceStructure * No Extension in mode
…into service_mode_extension
herlitze
previously approved these changes
Aug 28, 2020
pvgrumbkow
previously approved these changes
Aug 28, 2020
|
After thinking again about the proposed change, I don't know anymore, whether it would be wise. The proposal is to add an "Extension" to the DatedJourneyGroup. This group is part of DatedJourneyStructure and of ContinousServiceStructure. In both cases the DatedJourneyGroup is a choice. The result is, that some DatedJourneys and some ContinousServices wonÄ't have an extension. Wouldn't it be better and perhaps also more intuitive, if DatedJourneyStructure and ContinousServiceStrucute would each get an "Extension"? |
Change made. Extension is now in the Structure(s) and no longer in the group
|
Update made according to Peter's suggestion. |
pvgrumbkow
approved these changes
Sep 28, 2020
sgrossberndt
approved these changes
Oct 2, 2020
herlitze
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service and ModeStructure didn't have the Extension element.