-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding resolution of record element subtypes in packages #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Tcenova do you need this change to be released as v0.29.0 or is a merge to Currently, |
The |
Are you waiting because of the standalone installation feature or because of gathered additions to GHDL? |
May I asked if the pyVHDLModel is so far understandable. It doesn't have lots of documentation and it might not be easy to understand what I did and how I did it :). |
I am mainly waiting on the changes to pyGHDL that allow it to use the latest version of pyVHDLModel. Overall, I am trying to fully parse an entities ports and generics. I have some local code to also resolve subtypes of the ports which is only possible with the latest code. I am also trying to extract the constraints of ports and generics on an entity, hence why I opened ghdl/ghdl#2661
I cant say I have been able to understand the high level approach/reasoning for things yet, but I also haven't spent much time trying. There seems to be many layers, along with more layers added in the DOM in pyGHDL, so traversing through the layers has sometimes been a challenge. I am able to generally understand how to use things after looking at the different layers of source code though. |
Oh, ghdl/ghdl#2661. I didn't recognize your name from there. Sorry. I'll try to invest more time into it. (pending PR: ghdl/ghdl#2439) |
New Features