Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor weights #5

Merged
merged 6 commits into from
Mar 25, 2021
Merged

Anchor weights #5

merged 6 commits into from
Mar 25, 2021

Conversation

Cecilia-Sensalari
Copy link
Collaborator

  • anchor pairs are now weighted (function compute_weights_anchor_pairs())
  • removed the WeightOutlierIncluded column from the ks_anchor.tsv

lohausr
lohausr suggested changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@lohausr lohausr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some (small) changes.

ksrates/fc_extract_ks_list.py Outdated Show resolved Hide resolved
ksrates/fc_extract_ks_list.py Outdated Show resolved Hide resolved
ksrates/fc_extract_ks_list.py Outdated Show resolved Hide resolved
ksrates/fc_wgd.py Outdated Show resolved Hide resolved
ksrates/fc_wgd.py Outdated Show resolved Hide resolved
ksrates/fc_wgd.py Outdated Show resolved Hide resolved
@Cecilia-Sensalari
Copy link
Collaborator Author

  • compute_weight_anchor_pairs() moved to more suitable module
  • Delete in ks_list_from_tsv() redundant min_ks of 0.05

lohausr
lohausr suggested changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@lohausr lohausr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few doc changes, then it can be merged, I think.

ksrates/fc_wgd.py Outdated Show resolved Hide resolved
ksrates/fc_wgd.py Outdated Show resolved Hide resolved
ksrates/fc_wgd.py Outdated Show resolved Hide resolved
ksrates/fc_wgd.py Outdated Show resolved Hide resolved
ksrates/fc_wgd.py Outdated Show resolved Hide resolved
ksrates/fc_wgd.py Outdated Show resolved Hide resolved
ksrates/fc_wgd.py Outdated Show resolved Hide resolved
@Cecilia-Sensalari @lohausr
Apply suggestions from code review
844147f 
Co-authored-by: lohausr <56632794+lohausr@users.noreply.github.com>
@Cecilia-Sensalari Cecilia-Sensalari merged commit ba1fd0f into master Mar 25, 2021
@Cecilia-Sensalari Cecilia-Sensalari deleted the anchor_weights branch March 25, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lohausr lohausr lohausr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cecilia-Sensalari @lohausr