Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolidJS tutorial features 1 & 2 #2

Merged
merged 17 commits into from
Apr 25, 2024
Merged

Conversation

VJftw
Copy link
Owner

@VJftw VJftw commented Mar 15, 2024

This PR adds support for SolidJS features from the tutorial from 1a to 2g including tested examples.

@VJftw VJftw force-pushed the solidjs-feature-examples-and-tests branch 10 times, most recently from 35ed800 to c558f59 Compare March 20, 2024 23:27
@VJftw VJftw force-pushed the solidjs-feature-examples-and-tests branch 2 times, most recently from d70f316 to 7ae68d9 Compare April 5, 2024 19:37
@VJftw VJftw force-pushed the solidjs-feature-examples-and-tests branch from 7ae68d9 to 964593e Compare April 19, 2024 18:03
@VJftw VJftw force-pushed the solidjs-feature-examples-and-tests branch 2 times, most recently from 8a4237b to baa7db9 Compare April 20, 2024 00:42
@VJftw VJftw marked this pull request as ready for review April 20, 2024 00:44
@VJftw VJftw marked this pull request as draft April 20, 2024 00:44
@VJftw
Copy link
Owner Author

VJftw commented Apr 20, 2024

Todo: make sure to support empty slices in for and index

@VJftw VJftw force-pushed the solidjs-feature-examples-and-tests branch from a10fa16 to c2491ae Compare April 22, 2024 19:19
@VJftw VJftw changed the title WIP: SolidJS examples and tests SolidJS tutorial features 1 & 2 Apr 25, 2024
@VJftw VJftw marked this pull request as ready for review April 25, 2024 21:33
@VJftw VJftw merged commit d107f78 into main Apr 25, 2024
3 checks passed
@VJftw VJftw deleted the solidjs-feature-examples-and-tests branch April 25, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant