docs(styleguide): fix configuration #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Почему-то собственная обёртка не использовался, а бралась из либы `@rsg-components/*`.
`contentTitle` полезен когда необходимо добавить в заголовок страницы дополнительную мета инфоррмацию. Например, добавить префикс перед `title`.
👀 Docs deployedCommit 64627ad |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 64627ad:
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5523 +/- ##
=======================================
Coverage 81.69% 81.69%
=======================================
Files 286 286
Lines 9575 9575
Branches 3054 3054
=======================================
Hits 7822 7822
Misses 1753 1753
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eugpoloz
approved these changes
Jul 26, 2023
SevereCloud
approved these changes
Jul 26, 2023
BlackySoul
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SectionRendererНе использовался созданный
styleguide/Components/Section/SectionRenderer.js, а бралась из либы@rsg-components/*. Из-за чего для заголовка страницы применялсяname(текст, который используется как имя страницы), а неtitle(текст, который отображается в слева в меню)Было
Стало
contentTitleЗаодно добавил новый параметр, который позволит задавать свой заголовок страницы.
Полезно когда хотим отметить принадлежность страницы к какой-либо группе.
Пример из #5496. Отмечаем, что эта страницы является подразделом.