Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vk-bridge insets deprecation #6071

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

inomdzhon
Copy link
Contributor

Описание

  • Для аргумента useInsets(disabled: boolean) некорректно определялся предикат.
  • В PR feat: deprecate vk-bridge #5496 пропустил депрекейт хока withInsets(). Обновил документ по миграции на v6.

@inomdzhon inomdzhon added this to the v5.10.0 milestone Nov 2, 2023
@inomdzhon inomdzhon self-assigned this Nov 2, 2023
@inomdzhon inomdzhon requested a review from a team as a code owner November 2, 2023 10:54
@github-actions github-actions bot added patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5 labels Nov 2, 2023
Copy link
Contributor

github-actions bot commented Nov 2, 2023

size-limit report 📦

Path Size
JS 332.4 KB (+0.01% 🔺)
JS (gzip) 101.55 KB (+0.02% 🔺)
JS (brotli) 83.85 KB (+0.04% 🔺)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 255.17 KB (0%)
CSS (gzip) 33.55 KB (0%)
CSS (brotli) 27.25 KB (0%)

Copy link

codesandbox-ci bot commented Nov 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c3ac649:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

github-actions bot commented Nov 2, 2023

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 2, 2023

👀 Docs deployed

Commit c3ac649

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3a844db) 79.26% compared to head (c3ac649) 79.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6071      +/-   ##
==========================================
+ Coverage   79.26%   79.34%   +0.08%     
==========================================
  Files         306      306              
  Lines        9612     9617       +5     
  Branches     3254     3255       +1     
==========================================
+ Hits         7619     7631      +12     
+ Misses       1993     1986       -7     
Flag Coverage Δ
unittests 79.34% <66.66%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/vkui/src/components/AppRoot/AppRoot.tsx 92.24% <100.00%> (+0.06%) ⬆️
packages/vkui/src/hoc/withInsets.tsx 36.36% <50.00%> (+7.79%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Класс, спасибо! 🔥

@inomdzhon inomdzhon requested a review from a team November 2, 2023 11:57
@inomdzhon inomdzhon merged commit 6338e72 into master Nov 2, 2023
26 of 27 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/fix/vk-bridge-insets-deprecation branch November 2, 2023 15:42
@vkcom-publisher
Copy link
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке v5.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку v5, выполните следующие действия:

  1. Создайте новую ветку от v5 и примените изменения используя cherry-pick
git stash # опционально
git fetch origin v5
git checkout -b patch/pr6071 origin/v5

git cherry-pick --no-commit 6338e72667e17ca95f2671abcc33b8423f72684a
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой v5 (установка лейбла не требуется!)
git push --set-upstream origin patch/pr6071
gh pr create --base v5 --title "patch: pr6071" --body "- patch #6071"

inomdzhon added a commit that referenced this pull request Nov 2, 2023
* fix(AppRoot): fix useInsets predicate for disable
* fix: deprecate withInsets
@inomdzhon inomdzhon mentioned this pull request Nov 2, 2023
@VKCOM VKCOM deleted a comment from vkcom-publisher Nov 2, 2023
@inomdzhon inomdzhon removed the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Nov 2, 2023
inomdzhon added a commit that referenced this pull request Nov 3, 2023
* fix(AppRoot): fix useInsets predicate for disable
* fix: deprecate withInsets
@vkcom-publisher
Copy link
Contributor

v5.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical task type:bug v5 Автоматизация: PR продублируется в ветку v5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants