Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch(v5): pr6309 #6399

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented Jan 18, 2024


Важно

Это cherry-pick из #6309, из v6 в v5.

Измененияю

Убираем border-radius у ActionSheetItem на desktop, потому что при hover-эффекте загруглений не должно быть видно. Проверяем hover-эффект в e2e тестах.

Убираем border-radius у ActionSheetItem на desktop, потому что при hover-эффекте загруглений не должно быть видно.
Проверяем hover-эффект в e2e тестах.
@github-actions github-actions bot added patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5 labels Jan 18, 2024
@mendrew mendrew removed the v5 Автоматизация: PR продублируется в ветку v5 label Jan 18, 2024
@mendrew mendrew self-assigned this Jan 18, 2024
@mendrew mendrew added this to the v5.10.1 milestone Jan 18, 2024
Copy link
Contributor

github-actions bot commented Jan 18, 2024

size-limit report 📦

Path Size
JS 370.72 KB (0%)
JS (gzip) 111.62 KB (0%)
JS (brotli) 90.55 KB (0%)
JS import Div (tree shaking) 2.74 KB (0%)
CSS 285.59 KB (+0.01% 🔺)
CSS (gzip) 36.55 KB (+0.01% 🔺)
CSS (brotli) 29.1 KB (+0.03% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b9e72f6:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jan 18, 2024

👀 Docs deployed

Commit b9e72f6

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v5@596613d). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             v5    #6399   +/-   ##
=====================================
  Coverage      ?   80.66%           
=====================================
  Files         ?      314           
  Lines         ?    10805           
  Branches      ?     3369           
=====================================
  Hits          ?     8716           
  Misses        ?     2089           
  Partials      ?        0           
Flag Coverage Δ
unittests 80.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mendrew mendrew marked this pull request as ready for review January 18, 2024 09:38
@mendrew mendrew requested a review from a team as a code owner January 18, 2024 09:38
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Jan 18, 2024
@mendrew mendrew merged commit 7742a79 into v5 Jan 18, 2024
47 checks passed
@mendrew mendrew deleted the mendrew/v5/cherry-pick-from-v6/e3ec2450417be96487119421af17073a4cec9e63 branch January 18, 2024 11:47
vkcom-publisher pushed a commit that referenced this pull request Jan 18, 2024
…6399)

Убираем border-radius у ActionSheetItem на desktop, потому что при hover-эффекте загруглений не должно быть видно.
Проверяем hover-эффект в e2e тестах.
@inomdzhon inomdzhon removed the v5 Автоматизация: PR продублируется в ветку v5 label Jan 18, 2024
@inomdzhon inomdzhon changed the title fix(ActionSheetItem): hover on desktop without border-radius (#6309) patch(v5): pr6309 Jan 26, 2024
@inomdzhon inomdzhon removed this from the v5.10.1 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: У ActionSheetItem некорректная подсветка
3 participants