Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch(v5): pr6637 #6641

Merged
merged 1 commit into from
Feb 28, 2024
Merged

patch(v5): pr6637 #6641

merged 1 commit into from
Feb 28, 2024

Conversation

* fix(ModalPage): apply DOM changes before height calculation

* fix(ModalPage): apply DOM changes before height calculation
@BlackySoul BlackySoul requested a review from a team as a code owner February 28, 2024 04:28
@BlackySoul BlackySoul added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 28, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 372.22 KB (+0.01% 🔺)
JS (gzip) 112.15 KB (+0.02% 🔺)
JS (brotli) 91.03 KB (+0.09% 🔺)
JS import Div (tree shaking) 2.74 KB (0%)
CSS 286.13 KB (0%)
CSS (gzip) 36.68 KB (0%)
CSS (brotli) 29.16 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v5@3919ac8). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             v5    #6641   +/-   ##
=====================================
  Coverage      ?   80.65%           
=====================================
  Files         ?      314           
  Lines         ?    10874           
  Branches      ?     3389           
=====================================
  Hits          ?     8770           
  Misses        ?     2104           
  Partials      ?        0           
Flag Coverage Δ
unittests 80.65% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul merged commit 044a8af into v5 Feb 28, 2024
25 checks passed
@BlackySoul BlackySoul deleted the fix/patch_pr6637 branch February 28, 2024 10:07
vkcom-publisher pushed a commit that referenced this pull request Feb 28, 2024
* fix(ModalPage): apply DOM changes before height calculation

* fix(ModalPage): apply DOM changes before height calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
3 participants