Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): use conditional render #7011

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Jun 12, 2024

Описание

Select рендерит сразу два поля

image

Изменения

Используем useAdaptivityConditionalRender для скрытия лишнего поля

@SevereCloud SevereCloud requested a review from a team as a code owner June 12, 2024 07:31
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jun 12, 2024
@SevereCloud SevereCloud self-assigned this Jun 12, 2024
@SevereCloud SevereCloud added this to the v6.1.2 milestone Jun 12, 2024
Copy link
Contributor

github-actions bot commented Jun 12, 2024

size-limit report 📦

Path Size
JS 363.52 KB (+0.03% 🔺)
JS (gzip) 111.37 KB (+0.03% 🔺)
JS (brotli) 91.72 KB (+0.05% 🔺)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 275.82 KB (-0.04% 🔽)
CSS (gzip) 35.96 KB (-0.05% 🔽)
CSS (brotli) 29.14 KB (+0.03% 🔺)

Copy link

codesandbox-ci bot commented Jun 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jun 12, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jun 12, 2024

👀 Docs deployed

Commit 4527f1c

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.40%. Comparing base (ae0b01d) to head (4527f1c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7011   +/-   ##
=======================================
  Coverage   83.40%   83.40%           
=======================================
  Files         352      352           
  Lines       10532    10536    +4     
  Branches     3496     3500    +4     
=======================================
+ Hits         8784     8788    +4     
  Misses       1748     1748           
Flag Coverage Δ
unittests 83.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тесты падают и похоже что не зря, в доке для платформы vkcom селект не рендерится.

Screenshot 2024-06-13 at 13 44 44

@SevereCloud SevereCloud marked this pull request as draft June 13, 2024 11:04
@SevereCloud SevereCloud marked this pull request as ready for review June 14, 2024 14:19
@SevereCloud SevereCloud requested a review from mendrew June 14, 2024 14:19
@SevereCloud SevereCloud merged commit 9172a17 into master Jun 17, 2024
30 of 48 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/Select/use-conditional-render branch June 17, 2024 10:51
vkcom-publisher pushed a commit that referenced this pull request Jun 17, 2024
* fix(Select): use conditional render
* fix: deviceType forced is need display
@vkcom-publisher
Copy link
Contributor

v6.1.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:select patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча type:bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants