Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Clickable): lockState block events #7029

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

SevereCloud
Copy link
Contributor


Описание

lockState блокировал обработку всех событий, из-за чего состояния не сбрасывались

Изменения

Пробрасываем в хуки lockState и не влияем на hasHover и hasActive

lockState блокировал обработку всех событий, из-за чего состояния не сбрасывались

- fixes #6322
@SevereCloud SevereCloud requested a review from a team as a code owner June 18, 2024 09:45
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jun 18, 2024
Copy link
Contributor

github-actions bot commented Jun 18, 2024

size-limit report 📦

Path Size
JS 364.05 KB (+0.01% 🔺)
JS (gzip) 111.48 KB (+0.02% 🔺)
JS (brotli) 91.83 KB (+0.08% 🔺)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 279.17 KB (0%)
CSS (gzip) 36.34 KB (0%)
CSS (brotli) 29.44 KB (0%)

Copy link

codesandbox-ci bot commented Jun 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jun 18, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jun 18, 2024

👀 Docs deployed

Commit 0a689a0

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.42%. Comparing base (9172a17) to head (0a689a0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7029      +/-   ##
==========================================
- Coverage   83.43%   83.42%   -0.01%     
==========================================
  Files         353      353              
  Lines       10550    10548       -2     
  Branches     3505     3503       -2     
==========================================
- Hits         8802     8800       -2     
  Misses       1748     1748              
Flag Coverage Δ
unittests 83.42% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тест с hover падает

FAIL src/components/Tappable/Tappable.test.tsx
● Tappable › hover › nested hover › unhovers on child hover

@SevereCloud SevereCloud requested a review from mendrew June 18, 2024 10:42
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Шикарно, спасибо! 👍

Интересно, что ripple эффект распространяется и на родителя Tappable.

Screen.Recording.2024-06-18.at.13.48.47.mov

@SevereCloud SevereCloud merged commit 2566673 into master Jun 19, 2024
26 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue6322 branch June 19, 2024 10:41
vkcom-publisher pushed a commit that referenced this pull request Jun 19, 2024
lockState блокировал обработку всех событий, из-за чего состояния не сбрасывались

- fixes #6322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: заедает состояние с вложенными Clickable
3 participants