-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Clickable): lockState block events #7029
Conversation
lockState блокировал обработку всех событий, из-за чего состояния не сбрасывались - fixes #6322
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 0a689a0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7029 +/- ##
==========================================
- Coverage 83.43% 83.42% -0.01%
==========================================
Files 353 353
Lines 10550 10548 -2
Branches 3505 3503 -2
==========================================
- Hits 8802 8800 -2
Misses 1748 1748
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тест с hover падает
FAIL src/components/Tappable/Tappable.test.tsx
● Tappable › hover › nested hover › unhovers on child hover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Шикарно, спасибо! 👍
Интересно, что ripple эффект распространяется и на родителя Tappable.
Screen.Recording.2024-06-18.at.13.48.47.mov
lockState блокировал обработку всех событий, из-за чего состояния не сбрасывались - fixes #6322
Описание
lockState
блокировал обработку всех событий, из-за чего состояния не сбрасывалисьИзменения
Пробрасываем в хуки
lockState
и не влияем наhasHover
иhasActive