Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FixedLayout): add resize observer for resize component #7073

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor


Описание

Добавил подписку на изменения размеров родителя (или колонки) и пересчет размеров FixedLayout

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner June 25, 2024 13:07
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jun 25, 2024
Copy link
Contributor

github-actions bot commented Jun 25, 2024

size-limit report 📦

Path Size
JS 364.75 KB (+0.03% 🔺)
JS (gzip) 111.66 KB (+0.05% 🔺)
JS (brotli) 91.92 KB (-0.01% 🔽)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 286.51 KB (0%)
CSS (gzip) 37.18 KB (0%)
CSS (brotli) 30.04 KB (0%)

Copy link

codesandbox-ci bot commented Jun 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jun 25, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jun 25, 2024

👀 Docs deployed

Commit 83acd10

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.59%. Comparing base (4ee1f30) to head (83acd10).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7073      +/-   ##
==========================================
+ Coverage   83.57%   83.59%   +0.01%     
==========================================
  Files         352      352              
  Lines       10547    10535      -12     
  Branches     3489     3489              
==========================================
- Hits         8815     8807       -8     
+ Misses       1732     1728       -4     
Flag Coverage Δ
unittests 83.59% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft June 26, 2024 10:02
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

юниты упали 🤔


UPD

Вижу, пока ревьюл, в Draft перевёл

packages/vkui/src/components/FixedLayout/FixedLayout.tsx Outdated Show resolved Hide resolved
packages/vkui/src/hooks/useResizeObserver.ts Outdated Show resolved Hide resolved
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review June 26, 2024 13:40
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@inomdzhon inomdzhon removed the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jun 26, 2024
@inomdzhon inomdzhon merged commit 3ab7643 into master Jun 27, 2024
26 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/2429/resize-panel-header branch June 27, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants